Skip to content

Trailing whitespace is not removed by formatter on 'empty' lines #4984

Closed
Closed
Trailing whitespace is not removed by formatter on 'empty' lines#4984
Labels
BugA bug in TypeScriptFixedA PR has been merged for this issueHelp WantedYou can do this
Milestone
TypeScript 1.8

Description

@myitcv
Paul Jolly (myitcv)
opened on Sep 26, 2015

The following test fails:

/// <reference path='fourslash.ts' />

////    /*1*/
////    /*2*/

format.document();
verify.currentFileContentIs("\n");

(where the contents before marker 2 are a \t character)

I notice trailing whitespace is not removed from comments; whilst I would argue trailing whitespace should be removed across the board, I think it should at least be removed from lines only containing whitespace.

Thoughts?

Activity

  1. mhegazy commented on Sep 28, 2015

    @mhegazy
    Mohamed Hegazy (mhegazy)
    on Sep 28, 2015
    Contributor

    We do not touch comments, and this is by design. comments are not code, and should not be formatted.
    as for empty lines, this is more of an optimization, and can be removed.

  2. Mohamed Hegazy (mhegazy)
    added
    BugA bug in TypeScript
    Help WantedYou can do this
    on Sep 28, 2015
  3. Mohamed Hegazy (mhegazy)
    added this to the milestone on Sep 28, 2015

  4. myitcv commented on Sep 28, 2015

    @myitcv
    Paul Jolly (myitcv)
    on Sep 28, 2015
    Author

    comments are not code, and should not be formatted.

    Thanks for confirming this is the position as far as TypeScript is concerned.

  5. Mohamed Hegazy (mhegazy)
    closed this as completedin #5983on Jan 8, 2016
  6. Mohamed Hegazy (mhegazy)
    modified the milestones: TypeScript 1.8, on Jan 8, 2016
  7. Mohamed Hegazy (mhegazy)
    added
    FixedA PR has been merged for this issue
    on Jan 8, 2016

  8. mhegazy commented on Jan 8, 2016

    @mhegazy
    Mohamed Hegazy (mhegazy)
    on Jan 8, 2016
    Contributor

    thanks Kagami Sascha Rosylight (@saschanaz)!

  9. microsoft
    locked and limited conversation to collaborators on Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugA bug in TypeScriptFixedA PR has been merged for this issueHelp WantedYou can do this

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions