Repository navigation
5.5.0 regression - Named exports of functions are not emitted for CommonJS #58473
Description
🔎 Search Terms
commonjs export
🕗 Version & Regression Information
- This changed between versions 5.4.5 and 5.5.0
⏯ Playground Link
💻 Code
function foo(): void {
}
export {
foo,
};🙁 Actual behavior
ts 5.5.0-beta and 5.5.0-dev-20240508 both emit:
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
exports.foo = void 0;
function foo() {
}note missing last line
🙂 Expected behavior
ts 5.4.5 emit
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
exports.foo = void 0;
function foo() {
}
exports.foo = foo;Additional information about the issue
No response
Activity
[-]Named exports of functions are not emitted for CommonJS[/-][+]5.5.0 regression - Named exports of functions are not emitted for CommonJS[/+]Knagis commentedon May 8, 2024
the problem shows up only with functions. exporting classes or variables via
export { foo }work fine. alsoexport function foo() {}works fine.jakebailey commentedon May 9, 2024
Most likely this was #57669 (you could try using https://www.npmjs.com/package/every-ts to bisect and verify).
Knagis commentedon May 9, 2024
Bisect confirms that it is the cause
jakebailey commentedon May 9, 2024
Yeah, the issue appears to be that
collectExternalModuleInfodoesn't do the same thing it does for function declarations when processing export declarations.Knagis commentedon May 28, 2024
Jake Bailey (@jakebailey) is there a chance the fix for this could be merged before 5.5.1?
jakebailey commentedon Aug 20, 2024
What version of TS is the above output from? Is that expected output? Unexpected output?
That output is assigning
mockedClassComponentto the exports, not omitting it entirely, so I don't think what you've described is the same thing (and shows that the current state is working).meriouma commentedon Aug 20, 2024
Sorry, I think I was tracking the wrong issue.