Repository navigation
ts.server.ProjectService.closeConfiguredProject returns true on success. - #18180
Merged
Merged
Conversation
Fixes microsoft#17892 The if condition around the return value of that method in closeExternalProject indicates that this was the expected behavior.
|
Adrian Leonhard (@NaridaL), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17892
The if condition around the return value of that method in closeExternalProject indicates that this was the expected behavior.
I didn't find any tests (I searched for
ts.serverin path tests/cases). If one is required, where would it go?