Repository navigation
JSON.parse(), JSON.stringify() more specific declarations for #6955 - #28270
Conversation
|
|
AnyhowStep
changed the title
|
Shouldn't |
|
Ah, yes. That makes sense. Personally, I'm in favour of it now that you've pointed it out but I think it might break code for a lot of people. [EDIT] To elaborate, I think changing it to But I'm not sure how the TS team feels about such a change. |
| * @param space Adds indentation, white space, and line break characters to the return-value JSON text to make it easier to read. | ||
| */ | ||
| stringify(value: any, replacer?: (key: string, value: any) => any, space?: string | number): string; | ||
| stringify(value: any, replacer?: (this : any, key: string, value: any) => any, space?: string | number): string; |
There was a problem hiding this comment.
Can you remove the stray space?
Ryan Cavanaugh (RyanCavanaugh)
left a comment
Ryan Cavanaugh (RyanCavanaugh)
left a comment
There was a problem hiding this comment.
OK to merge after Monday
|
TypeScript Bot (@typescript-bot) test this please |
|
Heya Ryan Cavanaugh (@RyanCavanaugh), I've started to run the extended test suite on this PR at dd3ed02. You can monitor the build here. It should now contribute to this PR's status checks. |
|
Nothing relevant in RWC, GTG |
7 participants
Fixes #6955
I made a few comments in that issue about being unclear about how the whole PR process works,
And it seems I broke 5 tests,
I assume it's because they are expecting the previous signature for
JSON.parse()andJSON.stringify()but I've changed them.I'm not sure how to read the output files in
tests/baselines/localand decide if they're okay tobaseline-accept(which I assume updates the expected results) but I made a best-effort attempt to look through them and they seemed okay to me.