Repository navigation
Added validation for regex literals via RegExp constructor - #35957
Closed
Josh Ghoulberg 👻 (JoshuaKGoldberg) wants to merge 2 commits into
Closed
Josh Ghoulberg 👻 (JoshuaKGoldberg) wants to merge 2 commits into
Josh Ghoulberg 👻 (JoshuaKGoldberg) wants to merge 2 commits into
Conversation
Contributor
Author
|
TypeScript Bot (@typescript-bot) perf test |
4 tasks done
Member
This is why I'm really against taking a dependency in any way on the RegExp constructor. I'd rather we understand some basic set of regex sequences and report issues with them (e.g. parentheses matching) |
Contributor
Author
|
👍 I'll close this for now to keep the queue clean. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3432.
Edit: tests pass in Node 12 but not 8. Filed #35958