Repository navigation
Add a type-guard overload of Array.every - #38200
Ryan Cavanaugh (RyanCavanaugh) merged 2 commits into
Conversation
|
I've wanted this feature too, but it was pointed out in another issue that However, TS has other unsound narrowings, so maybe this should be a pragmatic exception? I'm not sure. Seems easy enough to wrap if you need it in a more sound way. |
|
Overall LGTM. Can you fix the merge conflict so we can run some user tests? |
|
TypeScript Bot (@typescript-bot) user test this |
|
Heya Nathan Shively-Sanders (@sandersn), I've started to run the parallelized community code test suite on this PR at b89c084. You can monitor the build here. |
|
Heya Nathan Shively-Sanders (@sandersn), I've started to run the parallelized Definitely Typed test suite on this PR at b89c084. You can monitor the build here. |
|
TypeScript Bot (@typescript-bot) rwc test this |
|
TypeScript Bot (@typescript-bot) test this |
|
Heya Nathan Shively-Sanders (@sandersn), I've started to run the extended test suite on this PR at b89c084. You can monitor the build here. |
|
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
|
User tests are fine -- we caught vs code during a build break, but otherwise there's nothing there. |
This adds a type-guard aware overload of
Array.every.Fixes #14963.