Repository navigation
When caching type references cache the tracked symbols so they can be emitted in the d.ts file - #51721
Merged
Conversation
TypeScript Bot (typescript-bot)
added
Author: Team
For Milestone Bug
Sheetal Nandi (sheetalkamat)
requested review from
Andrew Branch (andrewbranch) and
Wesley Wigham (weswigham)
December 2, 2022 02:00
Sheetal Nandi (sheetalkamat)
force-pushed
the
incremental
branch
from
December 7, 2022 01:20
47094fa to
8552d4e
Compare
…aration emitter to add imports
Sheetal Nandi (sheetalkamat)
force-pushed
the
incremental
branch
from
February 3, 2023 00:22
8552d4e to
74db34e
Compare
Wesley Wigham (weswigham)
approved these changes
Mar 15, 2023
Wesley Wigham (weswigham)
left a comment
Wesley Wigham (weswigham)
left a comment
Member
There was a problem hiding this comment.
Hm. Wouldn't have thought this'd matter, since tracking the symbol once should be enough to get all the marking done, but I guess since we mark and unmark late painted statements (?) there are edgecases where a track can add a node, then we traverse the node and remove it without serializing it (? why), then use it again and need to mark it again. Guess I'm just surprised this matters.
Member
|
Sheetal Nandi (@sheetalkamat) is this PR still useful, despite having been around for a while? |
… tracking symbols for recursive types
This was referenced Nov 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #51548