Repository navigation
With allowJs, process JS files found searching node_modules when they have a realpath outside node_modules - #56946
Merged
Andrew Branch (andrewbranch) merged 5 commits intoJan 10, 2024
Conversation
…th outside node_modules
TypeScript Bot (typescript-bot)
added
Author: Team
For Uncommitted Bug
Andrew Branch (andrewbranch)
requested review from
Nathan Shively-Sanders (sandersn) and
Sheetal Nandi (sheetalkamat)
January 4, 2024 16:53
Andrew Branch (andrewbranch)
requested a review
from Sheetal Nandi (sheetalkamat)
January 9, 2024 00:23
Sheetal Nandi (sheetalkamat)
approved these changes
Jan 10, 2024
Andrew Branch (andrewbranch)
deleted the
allow-js-across-monorepo-packages
branch
January 10, 2024 18:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically, treat JS files in other monorepo packages as local files, not untyped dependencies.
Re #56412 (comment)