Skip to content

Disallow void branches - #7261

Closed
Daniel Rosenwasser (DanielRosenwasser) wants to merge 7 commits into
masterfrom
noVoidBranches
Closed

Disallow void branches#7261
Daniel Rosenwasser (DanielRosenwasser) wants to merge 7 commits into
masterfrom
noVoidBranches

Conversation

@DanielRosenwasser

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) commented Feb 26, 2016

Copy link
Copy Markdown
Member

Fixes #7256

Open questions:

Should we cover null/undefined types?

TODO:

  • Conditional expressions
  • Negation expressions.

DanielRosenwasser
DanielRosenwasser reviewed Feb 26, 2016
View reviewed changes
Comment thread tests/baselines/reference/logicalAndOperatorWithEveryType.errors.txt

==== tests/cases/conformance/expressions/binaryOperators/logicalAndOperator/logicalAndOperatorWithEveryType.ts (10 errors) ====
// The && operator permits the operands to be of any type and produces a result of the same
// type as the second operand.

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) Feb 26, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might need to be updated. Should I split these tests up so we can observe the types of other expressions?

@sandersn Nathan Shively-Sanders (sandersn) Feb 26, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@sandersn

Nathan Shively-Sanders (sandersn) commented Feb 26, 2016

Copy link
Copy Markdown
Member

Why didn't we check this before? This seems fundamental to the type of binary logical operators.

@jeffreymorlan

jeffreymorlan commented Feb 26, 2016

Copy link
Copy Markdown
Contributor

void expressions should also be disallowed on the right side of !, I think.

@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Feb 27, 2016

Copy link
Copy Markdown
Member Author

jeffreymorlan that's not a bad idea either. Thanks!

Closed
@RyanCavanaugh

Ryan Cavanaugh (RyanCavanaugh) commented Mar 15, 2016

Copy link
Copy Markdown
Member

👍 and ✅

@mhegazy

Mohamed Hegazy (mhegazy) commented Apr 26, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

Daniel Rosenwasser (@DanielRosenwasser) can you update this PR.

@mhegazy

Mohamed Hegazy (mhegazy) commented Dec 30, 2016

Copy link
Copy Markdown
Contributor

Daniel Rosenwasser (@DanielRosenwasser) can you update and merge this time :)

@mhegazy

Mohamed Hegazy (mhegazy) commented May 22, 2017

Copy link
Copy Markdown
Contributor

Thanks for your contribution. This PR has failing CI tests and can not be merged in at the time being. For housekeeping purposes we are closing stale PRs. If you'd still like to merge this code in, please open a new PR that has been merged and rebased with the master branch.

@mhegazy
Mohamed Hegazy (mhegazy) deleted the noVoidBranches branch November 2, 2017 21:02
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@DanielRosenwasser @sandersn @jeffreymorlan @RyanCavanaugh @mhegazy @msftclas