Repository navigation
Update files modified by bootstrap - #2900
Merged
Merged
Conversation
Contributor
|
A lot of these were intentionally made to be marked as changed in git (so that it was easy to know all of the changes on an TypeScript version update) but I'm pretty sure they can be safely gitignored if that's more annoying than useful |
Member
Author
|
I don't mind them being committed per se, but the problem is that the CI doesn't actually error when bootstrap changes files and they aren't committed. That and I've frequently had issues with bootstrap in general not making changes unless I fully |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These files are modified in bootstrap because some of their source files changed. We have no mechanism to detect this at the moment so here's a fixup.