This repository was archived by the owner on Dec 7, 2021. It is now read-only.
Repository navigation
feat: Traditional Chinese language support - #949
Merged
Merged
Conversation
Jason Chou (harvinchou)
suggested changes
Mar 26, 2020
Jason Chou (harvinchou)
left a comment
Jason Chou (harvinchou)
left a comment
Contributor
There was a problem hiding this comment.
The translation is good! Just provided some suggested changes to make them more align with Azure's official terms.
Co-Authored-By: Jason Chou <[email protected]>
accepted suggestion. thanks for the feedback those make sense! Co-Authored-By: Jason Chou <[email protected]>
John Chang (ShuyuanChang)
suggested changes
Mar 26, 2020
John Chang (ShuyuanChang)
left a comment
John Chang (ShuyuanChang)
left a comment
Contributor
There was a problem hiding this comment.
I had suggested some general terms and pls check them.
thanks for the review, this is more close to normally a TW UI wording! appreciated! Co-Authored-By: John Chang <[email protected]>
My (mydiemho)
suggested changes
Mar 26, 2020
My (mydiemho)
left a comment
My (mydiemho)
left a comment
Contributor
There was a problem hiding this comment.
Please build a version locally and make sure all strings are rendered correctly. In the process of translation, a lot of the variables extrapolations are messed up. I mark some below but not all please double check
| }, | ||
| importProject: { | ||
| title: "匯入專案", // Import Project | ||
| confirmation: "您確定要將專案$ {project.file.name}的設定轉換為v2格式嗎？我們建議您首先備份專案文件。", |
Contributor
There was a problem hiding this comment.
please remove the space between $ and {project.file.name}.
| // We recommend you backup the project file first. | ||
| }, | ||
| messages: { | ||
| deleteSuccess: "已成功刪除$ {project.name}專案", // Successfully deleted ${project.name} |
| }, | ||
| addConnection: "新增連線", // Add Connection | ||
| messages: { | ||
| saveSuccess: "已成功保存$ {project.name}專案設定", // Successfully saved ${project.name} project settings |
| // As for this VOTT tool, translate "Assets" to "Image data" in Traditional Chinese, | ||
| // as "Asset" can be confusing if directly translated. | ||
| totalAssetCount: "圖像數據總數", // Total Assets | ||
| visitedAssets: "已檢視的圖像數據（$ {count}）", // Visited Assets (${count}) |
…rocess. thanks My Ho for pointing out!!
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
thanks My (@mydiemho) , I just updated 9 occurrence of those and committed. |
My (mydiemho)
approved these changes
Mar 29, 2020
My (mydiemho)
approved these changes
Mar 29, 2020
Phil (PIC123)
approved these changes
Apr 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Traditional Chinese translation verified by Rex Tang (@rextangtw)