Skip to content
This repository was archived by the owner on Dec 7, 2021. It is now read-only.

feat: Korean language support - #950

Merged
My (mydiemho) merged 11 commits into
microsoft:developfrom
aykhara:add-korean
Apr 27, 2020
Merged

feat: Korean language support #950
My (mydiemho) merged 11 commits into
microsoft:developfrom
aykhara:add-korean

Conversation

@aykhara

@aykhara Ayaka Hara (aykhara) commented Mar 25, 2020

Copy link
Copy Markdown
Contributor

Korean translation verified by Eunji Kim (@angie4u)

mydiemho
My (mydiemho) approved these changes Mar 26, 2020
View reviewed changes

@mydiemho My (mydiemho) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Have you build the app locally to make sure all the strings are rendered correctly?

@aykhara

Ayaka Hara (aykhara) commented Mar 27, 2020

Copy link
Copy Markdown
Contributor Author

My (@mydiemho) Thank you for taking the time to review this. Yes, I have built the app locally and worked correctly with all the strings on my side.

@angie4u

Eunji Kim (angie4u) commented Mar 27, 2020

Copy link
Copy Markdown
Contributor

Yeap! I also checked my side as well and it works fine! :)
I'm adding few screenshots on this ;)
image

image

image

image

@mydiemho

My (mydiemho) commented Apr 27, 2020

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

azure-pipelines Bot commented Apr 27, 2020

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@sonarqubecloud

sonarqubecloud Bot commented Apr 27, 2020

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mydiemho

My (mydiemho) commented Apr 27, 2020

Copy link
Copy Markdown
Contributor

Codecov is having issues updating GitHub again. Going to bypass and merge since the report show that coverage report is good https://codecov.io/gh/microsoft/VoTT/tree/058354be8e1be7a9a01b9f38314ebb2055796a39

@mydiemho
My (mydiemho) merged commit 2b68e21 into microsoft:develop Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@mydiemho My (mydiemho) mydiemho approved these changes
@PIC123 Phil (PIC123) PIC123 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aykhara @angie4u @mydiemho @PIC123 @tbarlow12