Skip to content

Distributions: Add Rocky Linux 9 and 10 - #13094

Closed
Lukas Magauer (lumarel) wants to merge 1 commit into
microsoft:masterfrom
lumarel:feature/distribution-rocky-linux
Closed

Distributions: Add Rocky Linux 9 and 10#13094
Lukas Magauer (lumarel) wants to merge 1 commit into
microsoft:masterfrom
lumarel:feature/distribution-rocky-linux

Conversation

@lumarel

@lumarel Lukas Magauer (lumarel) commented Jun 11, 2025

Copy link
Copy Markdown

Summary of the Pull Request

This PR will add Rocky Linux as a new distribution to the DistributionInfo.json list. More specifically the releases of 9.6 and 10.0.
The WSL images are hosted on the main CDN of the project and I made sure with releng that the links should not break in the future, even if the content is moved to the vault.

Further these images are built with KIWI-ng with these recipes: 9 and 10

And finally I looked at the PR for Fedora and hopefully checked everything that might be necessary, if there is anything I/we might be able to improve I'm sure going to do so! 🙂
(beside updating the image when we build a new version of course in the future)

Cheers, Lukas

PR Checklist

  • Closes: Link to issue
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here

@lumarel
Lukas Magauer (lumarel) requested a review from a team as a code owner June 11, 2025 21:53
@lumarel

Lukas Magauer (lumarel) commented Jun 12, 2025

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

craigloewen-msft
Craig Loewen (craigloewen-msft) approved these changes Jun 12, 2025
View reviewed changes

@craigloewen-msft Craig Loewen (craigloewen-msft) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried the distro out and looks great to me. Thanks for doing the work to add this!! :)

@lumarel

Lukas Magauer (lumarel) commented Jun 12, 2025

Copy link
Copy Markdown
Author

Cool!
Thanks for making it possible to add it 😇 (open source is great!)

@OneBlue

Blue (OneBlue) commented Jun 13, 2025

Copy link
Copy Markdown
Collaborator

Thank you for doing Lukas Magauer (@lumarel).

This looks good overall, but I want to point a couple things:

  1. /usr/libexec/wsl/oobe.sh manually writes the default user to /etc/wsl.conf. We don't recommend doing that since this can break wsl --manage <distro> --set-default-user, and shouldn't be needed since you already set defaultUid to 1000 in /etc/wsl-distribution.conf

  2. The tars all have the security.selinux extended attribute set, which breaks when importing the distribution with WSL1. Given that WSL2 doesn't support selinux, I'd recommend removing those to remain compatible with WSL1

You can use validate-modern.py to validate that the extended attributes are supported by WSL1. Sample usage:

pip install -r distributions\requirements.txt
python distributions\validate-modern.py --tar Rocky-9-WSL-Base-9.6-20250531.0.x86_64.wsl

Let me know what you'd like to do above those two, you get the final say as the distribution maintainer, but we definitely recommend fixing those before merging, since that will give your users a better experience.

OneBlue
Blue (OneBlue) requested changes Jun 17, 2025
View reviewed changes

@OneBlue Blue (OneBlue) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on maintainers to reply on above feedback

@jeremycline

Jeremy Cline (jeremycline) commented Jul 7, 2025

Copy link
Copy Markdown
Member

Thank you for doing Lukas Magauer (@lumarel).

This looks good overall, but I want to point a couple things:

  1. /usr/libexec/wsl/oobe.sh manually writes the default user to /etc/wsl.conf. We don't recommend doing that since this can break wsl --manage <distro> --set-default-user, and shouldn't be needed since you already set defaultUid to 1000 in /etc/wsl-distribution.conf

For what it's worth this is probably because I did this in Fedora (sorry) - it's now fixed there so if Rocky pulls the latest sources from Fedora Rawhide this particular issue will be addressed.

@lumarel

Lukas Magauer (lumarel) commented Jul 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Author

Took me a long time to get back on this (sorry, work ate my time)
That's a great hint, thanks for that, Jeremy Cline (@jeremycline). (beside I'm really happy to having had your implementation as template)

I will get that sorted out hopefully very soon.

@tinlittle

tinlittle commented Dec 8, 2025

Copy link
Copy Markdown

It's been 70 years meme inserted here.

@benhillis

Ben Hillis (benhillis) commented Mar 19, 2026

Copy link
Copy Markdown
Member

Closing old pull requests with no activity.

@pswartzclan Patrick Swartz (pswartzclan) mentioned this pull request Sep 27, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OneBlue Blue (OneBlue) OneBlue requested changes
@craigloewen-msft Craig Loewen (craigloewen-msft) craigloewen-msft approved these changes
@benhillis Ben Hillis (benhillis) Awaiting requested review from benhillis benhillis was automatically assigned from microsoft/wsl-maintainers
@justus-camp-microsoft justus-camp-microsoft Awaiting requested review from justus-camp-microsoft justus-camp-microsoft was automatically assigned from microsoft/wsl-maintainers

Assignees

@craigloewen-msft Craig Loewen (craigloewen-msft)

Labels

needs-author-feedback

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lumarel @OneBlue @jeremycline @tinlittle @benhillis @craigloewen-msft