Repository navigation
[release/2.7] Validate guest capability strings - #41569
Merged
Ben Hillis (benhillis) merged 1 commit intoSep 11, 2026
Merged
Ben Hillis (benhillis) merged 1 commit into
Ben Hillis (benhillis) merged 1 commit into
Conversation
Co-authored-by: Copilot <[email protected]> Copilot-Session: 3086bdaf-bc43-4fed-88d1-3a95a21fd14e
Blue (OneBlue)
approved these changes
Sep 10, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Regression coverage for malformed or truncated guest-capabilities Buffer is still required.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Backports bounded validation of guest capability strings and kernel version parsing for release/2.7.
Changes:
- Captures the received message span.
- Validates and parses the kernel version within that span.
- Updates parsing error diagnostics.
File summaries
| File | Reviewed changes | Final review status |
|---|---|---|
src/windows/service/exe/WslCoreVm.cpp |
Bounds guest capability string extraction and kernel version parsing. | Critical (1 vote): Add regression coverage for unterminated or truncated Buffer messages. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Ben Hillis (benhillis)
enabled auto-merge (squash)
September 10, 2026 23:36
Ben Hillis (benhillis)
deleted the
backport-message-buffer-validation-release-2.7
branch
September 11, 2026 01:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The WSLC disk-path portion does not apply because that component is not present on this release branch.
Testing