Repository navigation
Simplify event reader cleanup - #41667
Merged
beena352 merged 1 commit intoSep 21, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review comments; changes are limited to cleanup and an unused include removal.
Review effort: Lite
Findings: None
What changed in this PR
Simplifies event-reader cleanup in the network events E2E test and removes an unused header.
Changes:
- Resets the cleanup guard after stopping the reader.
- Removes the unused
<unordered_set>include.
| File | Description |
|---|---|
test/windows/wslc/e2e/WSLCE2EEventsTests.cpp |
Simplifies event-reader shutdown cleanup. |
src/windows/wslcsession/WSLCSession.h |
Removes an unused include. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Blue (OneBlue)
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Follow-up to simplify cleanup in the network events E2E test by resetting the scope guard directly after stopping the reader. Also removes an unused <unordered_set> include.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed