Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Add coverage for caller-process exit while blocked and simultaneous handle signaling.
Review effort: Lite
Findings: None
What changed in this PR
Refactors event-stream waits to monitor cancellation and caller-process handles together.
Changes:
- Uses
WaitForMultipleObjectsfor unified waiting. - Updates the
EventStorewait API and documentation. - Adds expanded cancellation and event-stream tests.
| File | Summary |
|---|---|
test/windows/WSLCTests.cpp |
Adds event-stream cancellation scenarios. |
src/windows/wslcsession/EventStore.h |
Updates the wait API and documentation. |
src/windows/wslcsession/EventStore.cpp |
Implements combined handle waiting; caller-exit interaction still needs test coverage. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Blue (OneBlue)
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Follow-up to combine event-stream cancellation and caller-exit handle checks.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Uses WaitForMultipleObjects() to check the optional cancellation and caller-process handles together. Adds event-stream cancellation coverage.
Validation Steps Performed