Repository navigation
Use a retry with timeout in HostPortCantBeBoundByGuest - #41728
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The retry logic is sound; only minor line-wrapping fixes were identified.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds bounded retries to stabilize mirrored-networking host-port binding tests while stale guest reservations expire.
Changes:
- Adds configurable retry timeout to
BindHostPort. - Keeps WSL alive during retries.
- Applies two-minute retries to TCP and UDP checks.
| File | Description |
|---|---|
test/windows/NetworkTests.cpp |
Adds retry-based host binding and updates the mirrored-networking test. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Daman Mulye (damanm24)
approved these changes
Sep 29, 2026
Ben Hillis (benhillis)
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This change adds logic to retry binding a host port with a fixed timeout. This is needed because GNS might not see a short bound port reservation, and if that happens, it will take 30 seconds for that binding to expire and become available on the host again
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed