Repository navigation
Don't fail configuring the consommé loopback adapter when ipv6 is disabled - #41729
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new test does not verify that IPv4 loopback traffic actually works after suppressing the IPv6 error.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Prevents Consomme networking from failing when IPv6 is disabled at boot.
Changes:
- Ignores expected missing IPv6 sysctl errors.
- Adds IPv6-disabled configuration coverage.
- Documents the behavior.
| File | Description |
|---|---|
src/linux/init/NetworkManager.cpp |
Continues IPv4 loopback setup after expected IPv6 errors. |
test/windows/NetworkTests.cpp |
Tests Consomme configuration without IPv6. |
doc/docs/technical-documentation/localhost.md |
Documents IPv6-disabled initialization. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| VERIFY_ARE_EQUAL(loopbackState.V4Addresses.size(), 1u); | ||
| VERIFY_ARE_EQUAL(loopbackState.V4Addresses[0].Address, L"169.254.73.250"); | ||
| VERIFY_ARE_EQUAL(loopbackState.V4Addresses[0].PrefixLength, 28u); | ||
| VERIFY_IS_TRUE(loopbackState.V6Addresses.empty()); |
Ben Hillis (benhillis)
approved these changes
Sep 29, 2026
Daman Mulye (damanm24)
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This changes updates the loopback configuration logic to ignore ipv6 failures when ipv6 is disabled inside the VM
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed