Skip to content

Revert "Enable RedirectionGuard process mitigation" - #41744

Merged
Ben Hillis (benhillis) merged 3 commits into
masterfrom
revert-41542-redirection-guard
Sep 30, 2026
Merged

Revert "Enable RedirectionGuard process mitigation"#41744
Ben Hillis (benhillis) merged 3 commits into
masterfrom
revert-41542-redirection-guard

Conversation

@OneBlue

@OneBlue Blue (OneBlue) commented Sep 30, 2026

Copy link
Copy Markdown
Collaborator

This change reverts #41542, to fix #41737

Copilot AI balanced review requested due to automatic review settings September 30, 2026 18:18
@OneBlue
Blue (OneBlue) requested a review from a team as a code owner September 30, 2026 18:18
Copilot AI reviewed Sep 30, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused revert directly addresses the reported junction traversal regression without altering other mitigations.

Review effort: Balanced
Findings: None

What changed in this PR

Reverts RedirectionGuard enforcement to restore support for Store distributions moved between drives.

Changes:

  • Removes the RedirectionGuard mitigation from shared process security setup.
  • Retains all existing mitigation policies.
File Description
src/​windows/​common/​WslSecurity.cpp Removes RedirectionGuard enforcement.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI balanced review requested due to automatic review settings September 30, 2026 18:21
Copilot AI reviewed Sep 30, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The new comment incorrectly says the reverted mitigation should be enabled.

Review effort: Balanced
Findings: 1 Low severity

Open (1)

Comment thread src/windows/common/WslSecurity.cpp Outdated
Copilot AI balanced review requested due to automatic review settings September 30, 2026 18:25
Copilot AI reviewed Sep 30, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The targeted revert addresses the reported regression; only a minor comment typo remains.

Review effort: Balanced
Findings: None

Resolved since last review (1)
Previously missed (1)

In code that hasn't changed since last review

Low severity Fix compound modifier hyphenation and stray space

src/​windows/​common/​WslSecurity.cpp:61

Please hyphenate the compound modifier and remove the stray space before the period in the issue reference.

@benhillis
Ben Hillis (benhillis) enabled auto-merge (squash) September 30, 2026 19:20
@benhillis
Ben Hillis (benhillis) merged commit 939e806 into master Sep 30, 2026
12 checks passed
@benhillis
Ben Hillis (benhillis) deleted the revert-41542-redirection-guard branch September 30, 2026 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@benhillis Ben Hillis (benhillis) benhillis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Distro moved to another drive via Settings fails to start after update to 3.0.1: MountDisk/0x800701c0 (untrusted mount point)

3 participants

@OneBlue @benhillis