Repository navigation
Implement container health notifications to wslc events - #41763
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused implementation correctly forwards health transitions and includes comprehensive end-to-end validation.
Review effort: Balanced
Findings: None
What changed in this PR
Adds container health-status transitions to the wslc events stream.
Changes:
- Maps Docker healthy/unhealthy events into WSLC container events.
- Records health events without changing container lifecycle state.
- Adds end-to-end coverage for text, filtering, and JSON output.
| File | Description |
|---|---|
src/windows/wslcsession/DockerEventTracker.h |
Defines health event types. |
src/windows/wslcsession/DockerEventTracker.cpp |
Maps Docker health actions. |
src/windows/wslcsession/WSLCContainer.cpp |
Records health events. |
test/windows/wslc/e2e/WSLCE2EEventsTests.cpp |
Tests live and historical health events. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Blue (OneBlue)
marked this pull request as ready for review
October 1, 2026 21:21
Ben Hillis (benhillis)
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This change adds support for listening to container health events via
wslc eventsPR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed