Repository navigation
Reuse EmptyObject for HCS NUMA configuration - #41768
Merged
Ben Hillis (benhillis) merged 1 commit intoOct 2, 2026
Merged
Ben Hillis (benhillis) merged 1 commit into
Ben Hillis (benhillis) merged 1 commit into
Conversation
Co-authored-by: Copilot <[email protected]>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused refactor preserves existing serialization behavior without unresolved issues.
Review effort: Balanced
Findings: None
What changed in this PR
Reuses the shared JSON empty-object type for HCS NUMA configuration while preserving {} serialization.
Changes:
- Removes the redundant NUMA type and serializer.
- Uses
wsl::shared::EmptyObjectfor optional NUMA topology.
| File | Description |
|---|---|
src/windows/common/hcs_schema.h |
Reuses the shared empty-object representation for NUMA. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Blue (OneBlue)
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reuse the shared
EmptyObjectJSON type for the HCS NUMA configuration instead of maintaining an identical local type and serializer.Follow-up to OneBlue's suggestion in #41741: #41741 (comment)
Validation
FormatSource.ps1