Repository navigation
Use a fallback gateway if no ipv4 gateway is available in consommé networking - #41779
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds a safeguard in Consommé networking to avoid using an unusable IPv4 default route (e.g., 0.0.0.0 from on-link VPN routes) by generating and applying a fallback IPv4 gateway to keep DNS/name resolution functional.
Changes:
- Detects missing/unspecified IPv4 gateway and generates a fallback based on the preferred client IPv4 address.
- Replaces any existing IPv4 default route with the generated gateway route and logs telemetry for both success/failure paths.
| File | Description |
|---|---|
| src/windows/common/ConsommeNetworking.cpp | Adds fallback gateway generation + route replacement when the best gateway is empty/unspecified to prevent broken DNS configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Ben Hillis (benhillis)
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This change solves a consommé networking issue that is triggered by a VPN setting an on-link (via 0.0.0.0) default route. This causes consommé to be configured with 0.0.0.0 as its DNS server, which breaks name resolution and can cause dockerd to time-out during boot.
This change solves the issue by adding logic to fallback to a generated gateway address in that scenario.
Unfortunately there's no easy way to add test coverage for this, since that would require setting up in VPN in the CI, which we don't have infrastructure for at this time
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed