Repository navigation
Test and fixes for concurrent updates to vectors - #2032
Merged
Merged
Conversation
…te needing to return 0
18 of 19 tasks
…st Environment.ProcessCount updates in flight at once, so 2x overallocation is probably fine
…roach; instead work backwards from expected collisions, and pick with a relatively low collision rate (~5%); update vector-sets.md with scheme
…osoft/garnet into users/kmontrose/VADDUpdates
…xed in a recent diskann-garnet
…uccess that insert or update vectors
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
VADD update result handling either reports inserts or, once corrected, prevents updates from being replicated through the AOF.
Review effort: Balanced
Findings: 3
Open (5)
What changed in this PR
Adds ordering guarantees and tests for concurrent Vector Set updates and replication.
Changes:
- Adds element-level locking and partitioned replay channels.
- Distinguishes DiskANN inserts from updates.
- Adds concurrent update/replication tests and documentation.
| File | Description |
|---|---|
website/docs/dev/vector-sets.md |
Documents element-ordering locks. |
test/standalone/Garnet.test.vectorset/RespVectorSetTests.cs |
Tests VADD overwrites. |
test/standalone/Garnet.test.vectorset/DiskANNServiceTests.cs |
Updates native result expectations. |
test/cluster/Garnet.test.cluster.vectorsets/VectorSets/ClusterVectorSetTests.cs |
Adds concurrent replication tests. |
libs/server/Storage/Session/MainStore/VectorStoreOps.cs |
Applies element locks to mutations. |
libs/server/Resp/Vector/VectorManager.Replication.cs |
Partitions VADD replay by element. |
libs/server/Resp/Vector/VectorManager.Locking.cs |
Implements element-level locks. |
libs/server/Resp/Vector/VectorManager.cs |
Configures locks and update results. |
libs/server/Resp/Vector/DiskANNService.cs |
Maps expanded native insert results. |
libs/server/API/GarnetApi.cs |
Removes unnecessary unsafe modifiers. |
Directory.Packages.props |
Upgrades diskann-garnet to 6.0.0. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Badrish Chandramouli (badrishc)
approved these changes
Oct 7, 2026
Tiago Nápoli (tiagonapoli)
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests:
VADDupdates to elements already in a Vector SetVADDupdatesVREMandVADDVSETATTRupdatesFixes:
VADDs during replication replayThis introduces a separate set of element-level locks to guarantee order in AOF matches order actually applied to log. It also splits
VADDreplays into multiple channels (in addition to the existing multiple tasks) to guarantee element updates on replicas are applied in AOF order.TODO:
VADDreturns1on updates, needs to return0; this requires a fix on the DiskANN sideVADDto measure impact of new locksvector-set.mdNew locking introduces basically no overhead when not contended.
Benchmark is 50 serial
VADDs of 128-dimension vectors.Before change (34d14a8)
After change (5ce41a7)