Repository navigation
Fix negative bitmap index normalization - #2123
Merged
Merged
Conversation
Copilot started reviewing on behalf of
Vasileios Zois (vazois)
September 10, 2026 00:16
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
BITCOUNT compares raw negative offsets before clamping, producing incorrect results when both indices precede the value.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates BITCOUNT/BITPOS negative index handling to clamp before-start offsets to zero and adds regression coverage.
Changes:
- Revises bitmap offset normalization and BITPOS bounds.
- Adds BYTE/BIT regression tests.
- Updates test-side expected-value helpers.
Metadata: Accurate overall; consider adding the [RESP] prefix and linked issue.
File summaries
| File | Description |
|---|---|
BitmapManager.cs |
Updates normalization and BITPOS bounds. |
BitmapManagerBitCount.cs |
Handles reversed negative BITCOUNT ranges. |
GarnetBitmapTests.cs |
Adds negative-offset regression coverage. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Vasileios Zois (vazois)
force-pushed
the
vazois/bitmap-negative-index
branch
from
September 10, 2026 00:22
cae94bc to
4ff7f57
Compare
Badrish Chandramouli (badrishc)
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing