Repository navigation
Update testcerts - #2202
Merged
Merged
Update testcerts#2202
Conversation
…signed so whatever, tweak cert validation callback to ignore more errors
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The validation change suppresses hostname mismatches, while new private-key paths conflict with test coverage, documentation, and compliance scanning.
Review effort: Balanced
Findings: 1
Open (3)
What changed in this PR
Refreshes expired TLS test certificates and adjusts test certificate validation.
Changes:
- Regenerates RSA and EC certificate fixtures.
- Renames the Garnet client key and adds the CA key.
- Broadens test-side chain-error handling.
| File | Description |
|---|---|
.gitignore |
Removes the old key exception. |
test/testcerts/testcert.pem |
Replaces the RSA certificate and embeds its key. |
test/testcerts/testcert.key.pem |
Replaces the separate RSA key. |
test/testcerts/garnet.key |
Removes the former EC client key. |
test/testcerts/garnet-cert.key |
Adds the renamed EC client key. |
test/testcerts/garnet-cert.crt |
Replaces the EC client certificate. |
test/testcerts/garnet-ca.key |
Adds the CA signing key. |
test/testcerts/garnet-ca.crt |
Replaces the CA certificate. |
test/standalone/Garnet.test/TestUtils.cs |
Accepts combined TLS policy errors containing chain errors. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Vasileios Zois (vazois)
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They've expired, regenerating them per the README and an amount of bloody minded brute forcing.