Skip to content

Sync CompletionItemLabelDetails with VS Code? #1307

Closed
Closed
Sync CompletionItemLabelDetails with VS Code?#1307
Labels
implemented
Milestone
3.17

Description

@KamasamaK
KamasamaK
opened on Jun 29, 2021

VS Code finalized their API to be more generic (see microsoft/vscode#39441). Should LSP be synced with those changes? Of course this would still need to accommodate the change made for #1193 so not a full sync.

Activity

  1. KamasamaK
    changed the title [-]Sync `CompletionItemLabelDetails`[/-] [+]Sync `CompletionItemLabelDetails` with VS Code?[/+] on Jun 29, 2021

  2. dbaeumer commented on Jul 2, 2021

    @dbaeumer
    Dirk Bäumer (dbaeumer)
    on Jul 2, 2021
    Member

    Yes, we should adapt this as soon as the new version of VS Code has shipped.

  3. KamasamaK commented on Jul 8, 2021

    @KamasamaK
    KamasamaK
    on Jul 8, 2021
    ContributorAuthor

    It has shipped in VS Code.

  4. dbaeumer commented on Jul 15, 2021

    @dbaeumer
    Dirk Bäumer (dbaeumer)
    on Jul 15, 2021
    Member

    And it is adapted in the next version of the LSP libs.

    Need to still doc it in the spec.

  5. Dirk Bäumer (dbaeumer)
    added this to the 3.17 milestone on Jul 15, 2021

  6. dbaeumer commented on Nov 2, 2021

    @dbaeumer
    Dirk Bäumer (dbaeumer)
    on Nov 2, 2021
    Member

    Implemented and added to spec.

  7. Dirk Bäumer (dbaeumer)
    closed this as completedon Nov 2, 2021
  8. Dirk Bäumer (dbaeumer)
    added
    implemented
    on Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    implemented

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions