Repository navigation
consomme: update smoltcp to 0.12.0 - #2733
Merged
Merged
Conversation
John Starks (jstarks)
previously approved these changes
Feb 4, 2026
|
This PR modifies files containing For more on why we check whole files, instead of just diffs, check out the Rustonomicon |
John Starks (jstarks)
previously approved these changes
Feb 4, 2026
Ben Hillis (benhillis)
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following PRs: #2633 and #2398 require features that are only available in a newer version of smoltcp. Since the linked PRs are already large in size, it makes sense to do the version upgrade and corresponding build fixes in a separate PR. Unfortunately, there have been some changes in smoltcp that add bloat to our dependency list. Despite trying a myriad of combinations to turn off various features, I wasn't able to reduce the number of requisite dependencies that we have to pull in as a result of doing this upgrade.