fix: report match counts in --stats for the local-index and brute-force paths - #149

Adds match and matched-line totals to local-index and brute-force --stats output.

Changes:

• Tracks totals in OutputWriter.
• Reports totals across search summaries.
• Preserves existing JSON statistics handling.

Suppressed comments (1)

tgrep-cli/src/output.rs:305

• The existing --stats integration tests only verify output ordering and do not assert the newly added totals. Please add brute-force and local-index assertions for multiple matches on one line and for a non-line output mode such as --count; a multiple-path case is also needed to catch counter leakage between runs.

    pub fn match_totals(&self) -> (u64, u64) {
        (self.total_matches, self.total_matched_lines)

• Files reviewed: 2/2 changed files
• Comments generated: 3
• Review effort level: Balanced

Suppressed comments (3)

tgrep-cli/src/output.rs:569

• The totals are only updated by write_match, but several successful local-search output modes return before calling it: -l at search.rs:1724, -c/--count-matches at search.rs:1729, quiet mode at search.rs:1719, and non-JSON binary output at search.rs:1742. Those commands now print 0 matches (0 matched lines) despite finding matches (for example, --no-index -c --stats). Record the FileMatches totals before the presentation-specific early returns, with the appropriate mode limits, rather than deriving stats solely from rendered match rows.

        self.total_matches += m.spans.len() as u64;

tgrep-cli/src/output.rs:305

• OutputWriter is shared across every command-line target (main.rs:1339-1351), so these totals are cumulative, while each local/brute-force target prints a stats line immediately. With two path arguments, the second summary therefore includes matches from the first; server-delegated summaries remain per-target because they count only that response. Reset or snapshot/delta the counters per search::run, or defer reporting to one invocation-level summary.

    pub fn match_totals(&self) -> (u64, u64) {
        (self.total_matches, self.total_matched_lines)

tgrep-cli/src/search.rs:1222

• The existing --stats integration tests only assert output ordering, so the newly reported values are untested. Add local-index and --no-index assertions covering multiple matches on one line, multiple positional paths, count/file-only output, inverted matches, and a multiline match; these cases exercise the counter semantics and would catch the incorrect totals above.

        let (matches, matched_lines) = writer.match_totals();
        eprintln!(
            "Search completed in {:.1}ms: {matches} matches ({matched_lines} matched lines)",
            elapsed.as_secs_f64() * 1000.0

• Files reviewed: 2/2 changed files
• Comments generated: 1
• Review effort level: Balanced

• Files reviewed: 5/5 changed files
• Comments generated: 2
• Review effort level: Balanced

Suppressed comments (1)

Previously missed (1) — in code that hasn't changed since the last review.

tgrep-cli/src/search.rs:1122

• When an older server omits file_stats, its rendered rows are insufficient for -l --stats and -q --stats. The old files_only path clamps every file to one matching line, while quiet sends max_count: 1 per file but receives rows from every matching file; counting all those rows therefore undercounts files-only searches and overcounts quiet searches versus the local and new-server paths. If file_stats is absent for either mode, retry without truncation and apply first-file filtering, or bypass the server rather than printing an incorrect total.

• Files reviewed: 5/5 changed files
• Comments generated: 0 new
• Review effort level: Balanced

Suppressed comments (1)

Previously missed (1) — in code that hasn't changed since the last review.

tgrep-cli/src/search.rs:1122

• This fallback cannot reconstruct the promised totals from an older server response. Before this change, a files-only request forced max_count to 1, so an upgraded CLI connected to a still-running old daemon reports only the first matching line for -l --stats (and multiline rows can likewise split one regex match across lines). Detect the missing file_stats before rendering and retry via the local path, or otherwise treat that server as incompatible, rather than emitting an incorrect total.

• Files reviewed: 6/8 changed files
• Comments generated: 0 new
• Review effort level: Balanced