Repository navigation
ran cargo clippy --allow-dirty --fix -- -Wclippy::use_self - #150
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are mechanical, type-correct refactors with no behavioral impact.
Pull request overview
Applies Clippy’s use_self refactor without changing behavior.
Changes:
- Replaces explicit type references with
Selfin implementations. - Uses
Selffor recursive enum and same-type parameter declarations.
File summaries
| File | Description |
|---|---|
tgrep-core/src/query.rs |
Simplifies QueryPlan references. |
tgrep-core/src/error.rs |
Simplifies error variant construction and matching. |
tgrep-core/src/encoding.rs |
Simplifies encoding variant references. |
tgrep-core/src/builder.rs |
Simplifies FileBytes matching. |
tgrep-cli/src/search.rs |
Simplifies search scope and file text matching. |
tgrep-cli/src/output.rs |
Simplifies color matching and Stats parameter typing. |
tgrep-cli/src/matching.rs |
Simplifies matcher variant references. |
tgrep-cli/src/glob_filter.rs |
Uses Self::default(). |
Review details
- Files reviewed: 8/8 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Shengyu Fu (shengyfu)
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.