Repository navigation
test: make stats detail check terminal-independent - #167
Merged
Shengyu Fu (shengyfu) merged 1 commit intoSep 30, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The targeted change correctly isolates stats behavior from ambient terminal detection.
Review effort: Balanced
Findings: None
What changed in this PR
Pins the stats test’s color mode to avoid terminal-dependent behavior.
Changes:
- Sets
ColorMode::Neverin the affected test.
| File | Description |
|---|---|
tgrep-cli/src/search.rs |
Makes the stats detail test deterministic across TTY and piped output. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Shengyu Fu (shengyfu)
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #166
Summary
stats_requests_match_detail_so_spans_are_available_to_countindependent of whether stdout is attached to a terminalColorMode::Never, so it tests the--statsbehavior rather than ambient TTY detectionValidation
script -qec ...)cargo fmt --all -- --checkcargo clippy --workspace -- -D warningsgit diff --checkcargo test --workspacereaches 286 passing CLI tests but this ARM VPS consistently hits an unrelated existing failure inserve::recovery_tests::subscription_recovery_detects_equal_size_writes_with_restored_mtime. The same failure reproduces on unmodified upstreammain; its isolated test passes. The test changed by this PR passes both normally and with stdout attached to a pseudo-terminal.