Skip to content

Should Keep Pressing CMD + DELETE still delete lines? #17143

Closed
Closed
Should Keep Pressing CMD + DELETE still delete lines?#17143
Labels
editor-commandsEditor text manipulation commandsfeature-requestRequest for new features or functionalityhelp wantedIssues identified as good community contribution opportunities
Milestone
Backlog

Description

@alfondotnet
Alfonso Embid-Desmet (alfondotnet)
opened on Dec 13, 2016
  • VSCode Version: 1.7.2 (1.7.2)
  • OS Version: OSX El capitan 10.11.5 (15F34)

Steps to Reproduce:

  1. Write some lines
  2. Hold CMD, and press DELETE multiple times

Result expected:
Should keep deleting lines after the initial line removal

Result observed:
The cursor stops at the beginning of the line.

image

Activity

  1. Kai Maetzel (kieferrm)
    assigned
    Peng Lyu (rebornix)
    and
    Alexandru Dima (alexdima)
    on Dec 14, 2016

  2. alexdima commented on Mar 1, 2017

    @alexdima
    Alexandru Dima (alexdima)
    on Mar 1, 2017
    Member

    alfonsoperez Pressing ctrl+backspace on Windows works for me. I just stopped to not make a too long gif, but it goes all the way to the top:
    17143

    Peng Lyu (@rebornix) Can you please check on OSX?

  3. Alexandru Dima (alexdima)
    added
    info-neededIssue requires more information from poster
    on Mar 1, 2017
  4. Alexandru Dima (alexdima)
    added this to the Backlog milestone on Mar 1, 2017

  5. alfondotnet commented on Mar 2, 2017

    @alfondotnet
    Alfonso Embid-Desmet (alfondotnet)
    on Mar 2, 2017
    ContributorAuthor

    It doesn't do that on OSX for me :(

  6. Alexandru Dima (alexdima)
    added
    macosIssues with VS Code on MAC/OS X
    on Mar 30, 2017

  7. alfondotnet commented on Apr 24, 2017

    @alfondotnet
    Alfonso Embid-Desmet (alfondotnet)
    on Apr 24, 2017
    ContributorAuthor

    Any update on this? :(

  8. alexdima commented on May 5, 2017

    @alexdima
    Alexandru Dima (alexdima)
    on May 5, 2017
    Member

    I have just tried it on a mac mini in the office.

    cmd + delete is bound to the command deleteAllLeft (i.e. it is not deleteWordLeft as I originally thought).

    The command is currently implemented to only delete to the left, it doesn't handle in any way the case where the cursor sits at column 1.

  9. Alexandru Dima (alexdima)
    removed
    info-neededIssue requires more information from poster
    on May 5, 2017

  10. alfondotnet commented on May 5, 2017

    @alfondotnet
    Alfonso Embid-Desmet (alfondotnet)
    on May 5, 2017
    ContributorAuthor

    Oh, I see... I missed that fact from your example, yes, the equivalent in OSX would be to hold the option key, and the behaviour is the same

  11. Alexandru Dima (alexdima)
    removed their assignment
    on May 19, 2017
  12. Alexandru Dima (alexdima)
    added
    editor-contribEditor collection of extras
    and removed
    macosIssues with VS Code on MAC/OS X
    on May 19, 2017

  13. alfondotnet commented on Jun 9, 2017

    @alfondotnet
    Alfonso Embid-Desmet (alfondotnet)
    on Jun 9, 2017
    ContributorAuthor

    alexandrudima I took at stab at it at #28392 , what do you think?

  14. alexdima commented on Jun 12, 2017

    @alexdima
    Alexandru Dima (alexdima)
    on Jun 12, 2017
    Member

    alfonsoperez I've assigned the PR for reviewing to Peng Lyu (@rebornix) , he adopted the deleteAllLeft command.

  15. Peng Lyu (rebornix)
    added
    feature-requestRequest for new features or functionality
    help wantedIssues identified as good community contribution opportunities
    on Aug 11, 2017
  16. Peng Lyu (rebornix)
    removed their assignment
    on Sep 5, 2017

  17. erlingur commented on May 4, 2018

    @erlingur
    Erlingur Þorsteinsson (erlingur)
    on May 4, 2018

    Was this ever worked out? I miss this from Sublime.

  18. alfondotnet commented on Jun 13, 2018

    @alfondotnet
    Alfonso Embid-Desmet (alfondotnet)
    on Jun 13, 2018
    ContributorAuthor

    Was this ever worked out? I miss this from Sublime.

    I hear ya!!, I am waiting for feedback on my PR to see if this could be merged, it'd be nice!

  19. BrodaNoel commented on Jun 26, 2018

    @BrodaNoel
    Broda Noel (BrodaNoel)
    on Jun 26, 2018

    Here I added a duplicated (:() for this one: #53021

  20. alfondotnet commented on Jun 26, 2018

    @alfondotnet
    Alfonso Embid-Desmet (alfondotnet)
    on Jun 26, 2018
    ContributorAuthor

    Broda Noel (@BrodaNoel) my PR #28392 just got merged last week, so I would expect this feature to be rolled out soon

  21. Alexandru Dima (alexdima)
    added
    editor-commandsEditor text manipulation commands
    and removed
    editor-contribEditor collection of extras
    on Nov 14, 2018

  22. lramos15 commented on Jul 19, 2019

    @lramos15
    Logan Ramos (lramos15)
    on Jul 19, 2019
    Member

    This appears to be implemented now, so I'm going to close the issue.

  23. Logan Ramos (lramos15)
    closed this as completedon Jul 19, 2019
  24. vscodebot
    locked and limited conversation to collaborators on Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    editor-commandsEditor text manipulation commandsfeature-requestRequest for new features or functionalityhelp wantedIssues identified as good community contribution opportunities

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions