Skip to content

Allow to resolve command in codeAction/resolve #176705

Description

@RblSb

I tried to make simple code action thats adds function signature argument with type, generated from function call. So i need to asynchronously compute argument type, then make edit, then call command with arguments with edit position to select added function argument.
But you cannot resolve edit and command because of vscode limitation:
#106410 (comment)
So i cannot make code action that will be added to context menu without computation lag, since codeAction/resolve is limited only to edits.
I hope that Johannes Rieken (@jrieken) can understand many use cases from allowing to lazily resolve edit and command in code actions, and allow to change them both in resolve. This should be minor change with removing such limitation, and this is already allowed by lsp spec?

Activity

  1. added this to the Backlog milestone on Mar 10, 2023
  2. added a commit that references this issue on Mar 28, 2023
    f0990c1
  3. added a commit that references this issue on Mar 28, 2023
    ce00cd7
  4. added
    unreleasedPatch has not yet been released in VS Code Insiders
    insiders-releasedPatch has been released in VS Code Insiders
    and removed
    unreleasedPatch has not yet been released in VS Code Insiders
    on Mar 28, 2023
  5. vscodenpa commented on Apr 24, 2023

    @vscodenpa

    This bug has been fixed in the latest release of VS Code Insiders!

    RblSb (@RblSb), you can help us out by commenting /verified if things are now working as expected.

    If things still don't seem right, please ensure you're on version 3a69e15 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

    Happy Coding!

  6. locked and limited conversation to collaborators on May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions