Repository navigation
Allow to resolve command in codeAction/resolve #176705
Copy link
Copy link
Closed
Labels
apiauthor-verification-requestedIssues potentially verifiable by issue authorIssues potentially verifiable by issue authoreditor-code-actionsEditor inplace actions (Ctrl + .)Editor inplace actions (Ctrl + .)feature-requestRequest for new features or functionalityRequest for new features or functionalityinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code Insidersverification-neededVerification of issue is requestedVerification of issue is requestedverifiedVerification succeededVerification succeeded
Milestone
Description
Activity
- addedfeature-requestRequest for new features or functionalityRequest for new features or functionalityeditor-code-actionsEditor inplace actions (Ctrl + .)Editor inplace actions (Ctrl + .)
on Mar 10, 2023 - added a commit that references this issue
on Mar 28, 2023 - added a commit that references this issue
on Mar 28, 2023 - addedunreleasedPatch has not yet been released in VS Code InsidersPatch has not yet been released in VS Code Insidersinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code Insidersand removedunreleasedPatch has not yet been released in VS Code InsidersPatch has not yet been released in VS Code Insiders
on Mar 28, 2023 - addedauthor-verification-requestedIssues potentially verifiable by issue authorIssues potentially verifiable by issue author
on Apr 24, 2023 This bug has been fixed in the latest release of VS Code Insiders!
RblSb (@RblSb), you can help us out by commenting
/verifiedif things are now working as expected.If things still don't seem right, please ensure you're on version 3a69e15 of Insiders (today's or later - you can use
Help: Aboutin the command palette to check), and leave a comment letting us know what isn't working as expected.Happy Coding!
- addedverification-neededVerification of issue is requestedVerification of issue is requested
on Apr 24, 2023 - locked and limited conversation to collaborators
on May 13, 2023
Metadata
Metadata
Assignees
Labels
apiauthor-verification-requestedIssues potentially verifiable by issue authorIssues potentially verifiable by issue authoreditor-code-actionsEditor inplace actions (Ctrl + .)Editor inplace actions (Ctrl + .)feature-requestRequest for new features or functionalityRequest for new features or functionalityinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code Insidersverification-neededVerification of issue is requestedVerification of issue is requestedverifiedVerification succeededVerification succeeded
I tried to make simple code action thats adds function signature argument with type, generated from function call. So i need to asynchronously compute argument type, then make
edit, then callcommandwith arguments witheditposition to select added function argument.But you cannot resolve
editandcommandbecause of vscode limitation:#106410 (comment)
So i cannot make code action that will be added to context menu without computation lag, since
codeAction/resolveis limited only to edits.I hope that Johannes Rieken (@jrieken) can understand many use cases from allowing to lazily resolve
editandcommandin code actions, and allow to change them both inresolve. This should be minor change with removing such limitation, and this is already allowed by lsp spec?