Repository navigation
TypeScript: DiagnosticsCategory Warning is not honored #24907
Description
The video below demonstrates tslint running as a language server plugin. Notice that the tslint warnings show up as errors. However, in the code the DiagnosticCategory is set to Warning.
This is the code that creates the diagnostic https://github.com/egamma/tslint-language-service/blob/master/src/index.ts#L61
Activity
mjbvz commentedon Apr 17, 2017
Looks like we don't set a severity on the diagnostics which causes them to all be marked as errors. Looking into fixing this
mjbvz commentedon Apr 17, 2017
Hmm, I don't see a
categoryfield on normalDiagnosticobjects in the TSServer protocol, only onDiagnosticWithLinePosition. Let me see if this field is sent anyways when you explicitly set in the TSLint pluginmjbvz commentedon Apr 17, 2017
I've opened microsoft/TypeScript#15237 to track adding
categoryto theDiagnosticobjects that tsserver returns to us. This seems like an oversight in the current protocol