Skip to content

Support for custom SymbolKind values #50186

Closed

Description

I've added Go to Symbols support to Todo+, and I had to pick a SymbolKind, but none of them makes sense for this extension, as it's not providing syntax highlighting for a programming language.

I think there should either be support for passing no value for SymbolKind (hiding the icon, this is not happening at the moment) or support for defining custom SymbKinds.

screen shot 2018-05-20 at 17 05 10

Activity

  1. jrieken commented on May 29, 2018

    @jrieken
    Contributor

    support for passing no value for SymbolKind (hiding the icon, this is not happening at the moment) or support for defining custom SymbKinds.

    We will not so custom icons because that puts a higher burden onto extension authors, esp when this bubbles up to the LSP which then means you can to provide icons matching various different IDEs/editors. Having no icon seems like an option but might also look weird when having mixed items, e.g. with and without icon...

  2. fabiospampinato commented on May 29, 2018

    @fabiospampinato
    ContributorAuthor

    We will not so custom icons because that puts a higher burden onto extension authors

    How so? They could just keep using one of the available SymbolKinds.

    Having no icon seems like an option but might also look weird when having mixed items, e.g. with and without icon...

    In my particular case I'm only providing file-level symbols, and there aren't any other symbols providers for that file type.

    IMO it would also be weird if 2 completely different things use the same symbol, i.e. maybe somebody uses SymbolKind.Field for fields while my extension uses it for projects, mostly just because that icon has the same color as projects in *.todo files highlighted by my extension.

  3. vscodebot commented on Sep 11, 2018

    @vscodebot

    This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

    If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

    Thanks for your understanding and happy coding!

  4. Q-back commented on Aug 31, 2022

    @Q-back

    Johannes Rieken (@jrieken)
    I'm confused. Do you mean that it will not be possible to provide custom icons for outline/symbol list? #51334
    On the other hand here you said it should be possible.

    Can you confirm if it's possible to provide custom icons for outline, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

*out-of-scopePosted issue is not in scope of VS CodeoutlineSource outline view issuesunder-discussionIssue is under discussion for relevance, priority, approach

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions