Skip to content

Queue data during pty launch delay Fixes: #29184 - #30106

Merged
Daniel Imms (Tyriar) merged 1 commit into
microsoft:masterfrom
cleidigh:terminal-q/imp
Jul 5, 2017
Merged

Daniel Imms (Tyriar) merged 1 commit into
microsoft:masterfrom
cleidigh:terminal-q/imp

Conversation

@cleidigh

@cleidigh Christopher Leidigh (cleidigh) commented Jul 4, 2017 •

Copy link
Copy Markdown
Contributor

Daniel Imms (@Tyriar)
see issue for discussion

Fixes: #29184

@mention-bot

Copy link
Copy Markdown

Christopher Leidigh (@cleidigh), thanks for your PR! By analyzing the history of the files in this pull request, we identified Daniel Imms (@Tyriar) and Benjamin Pasero (@bpasero) to be potential reviewers.

@Tyriar

Copy link
Copy Markdown
Contributor

This is just what I was looking for, nice job 😃

@Tyriar
Daniel Imms (Tyriar) merged commit b3e36f9 into microsoft:master Jul 5, 2017
@Tyriar Daniel Imms (Tyriar) added this to the July 2017 milestone Jul 5, 2017
@cleidigh

Copy link
Copy Markdown
Contributor Author

Daniel Imms (@Tyriar)
Cool !
One question, one comment:

If you have any issues or features you would like help on feel fear to ping me , I'm looking for the next thing to help out on and I have a decent amount of time.

FYI I'm going to post two odd rendering issues with the terminal I saw while working on this.

  • overflow of the code lens into the terminal
  • duplication of lines in the terminal when code is not full-screen

I have to catch these and do a screen capture before I can post the issues
Christopher

@cleidigh
Christopher Leidigh (cleidigh) deleted the terminal-q/imp branch July 5, 2017 18:23
@Tyriar

Copy link
Copy Markdown
Contributor

Christopher Leidigh (@cleidigh) if you're interested in terminal stuff specifically this query has the issues that I felt were good for contributors https://github.com/Microsoft/vscode/issues?q=is%3Aopen+is%3Aissue+label%3Aintegrated-terminal+label%3Abug+label%3A%22help+wanted%22

There is also upstream which has a bunch of smaller bugs https://github.com/sourcelair/xterm.js/issues?q=is%3Aopen+is%3Aissue+label%3Abug

@Tyriar Daniel Imms (Tyriar) changed the title Q data during pty launch delay Fixes: #29184 Queue data during pty launch delay Fixes: #29184 Jul 5, 2017
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unnecessary delay when opening a terminal

4 participants