Repository navigation
Fix DeleteAllLeft when executed from column 1 - #40876
Closed
Spencer (spalger) wants to merge 2 commits into
Closed
Spencer (spalger) wants to merge 2 commits into
Spencer (spalger) wants to merge 2 commits into
Conversation
|
|
Spencer (spalger)
changed the title
Author
|
This change is really small, tested, and very meaningful to me 😄 |
Contributor
|
I don't know why I still didn't merge this PR, will take a look. |
Contributor
|
Spencer (@spalger) thanks for your great effort, there are several corner cases, like multi cursor, not handled perfectly. #28392 addresses issue so I merged that pr. Sorry for not merging this one, thanks anyways for your contribution. |
Author
|
Fantastic, that works for me! Thanks Peng Lyu (@rebornix)! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16460
The logic is mostly taken from https://github.com/Microsoft/vscode/blob/master/src/vs/editor/common/controller/cursorDeleteOperations.ts#L132-L138