Repository navigation
Remove the border. Fix #48765 - #48825
Shizeng Zhou (shizengzhou) wants to merge 7 commits into
Conversation
| cursor: pointer; | ||
| height: 35px; | ||
| box-sizing: border-box; | ||
| border: 1px solid transparent; |
There was a problem hiding this comment.
Shizeng Zhou (@shizengzhou) not a good change, this border is needed when the tab.border color is set, see:
|
Maybe we should conditionally set this border if |
|
|
|
Benjamin Pasero (@bpasero) I have changed my code. |
|
Shizeng Zhou (@shizengzhou) I did not realize that we set a border color by default in dark and light theme and we cannot just remove it because the color is actually in use:
As you can see, there is a slight black line between the two tabs. I think a better approach would be to not use borders at all for this kind of separation and have it some other way... |
|
Benjamin Pasero (@bpasero) Now I don't use borders for the separations. |
|
Shizeng Zhou (@shizengzhou) how about keeping the border as is and letting the special case of having a border for the active tab use the |
Color the bottom border for the active tab's ::after element
|
I found a simpler way via fd7d510 Thanks for the work here, sorry for not pushing it 👍 |
3 participants
Benjamin Pasero (@bpasero) I remove the border to fix it.
