Repository navigation
Markdown and common toolbar icons consistency pass - #50484
Merged
Merged
Conversation
Benjamin Pasero (bpasero)
suggested changes
May 27, 2018
Benjamin Pasero (bpasero)
left a comment
Benjamin Pasero (bpasero)
left a comment
Contributor
There was a problem hiding this comment.
Cherry Wang (@chryw) the ellipsis icon seems a bit inconsistent now:
Search (new left, old right, seems to be smaller now):
Panel (new left, old right, seems to be much larger now):
Contributor
|
ping Cherry Wang (@chryw) @misolori |
Contributor
Author
|
Benjamin Pasero (@bpasero) will fix today |
Contributor
|
Cherry Wang (@chryw) thanks, I merged this to master for our June release 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#50438
@misolori Benjamin Pasero (@bpasero)
I did a consistency pass to some icons on the editor top right toolbar area.
There might be other icons could show up in that area. I only tested below icons and made sure they look good. Please let me know if this change makes other icons inconsistent.