Skip to content

Move EnvironmentVariableCollection API into ExtensionContext - #96061

Merged
Connor Peet (connor4312) merged 5 commits into
masterfrom
tyriar/extctx_envvarcollection
Apr 24, 2020
Merged

Connor Peet (connor4312) merged 5 commits into
masterfrom
tyriar/extctx_envvarcollection

Conversation

@Tyriar

Copy link
Copy Markdown
Contributor

Part of #46696

@Tyriar Daniel Imms (Tyriar) added this to the April 2020 milestone Apr 24, 2020
@Tyriar Daniel Imms (Tyriar) self-assigned this Apr 24, 2020
@Tyriar

Copy link
Copy Markdown
Contributor Author

Connor Peet (@connor4312) you can make your extension update change on this branch, I still need to fix up the tests before merging is all.

@connor4312

Copy link
Copy Markdown
Member

Bumping js-debug requires updating distro as well. To avoid getting out of lockstep, let me know when you're ready to merge this and then I'll merge and bump at the same time.

@Tyriar

Copy link
Copy Markdown
Contributor Author

Connor Peet (@connor4312) good to go, provided CI passes.

@Tyriar

Copy link
Copy Markdown
Contributor Author

Manually queued a build as it was stuck https://dev.azure.com/vscode/VSCode/_build/results?buildId=41874&view=results

@connor4312

Copy link
Copy Markdown
Member

Ok, cool. I'm out for a bit as mentioned, I'll bump, verify, and merge after standup.

@connor4312
Connor Peet (connor4312) merged commit 7f5bada into master Apr 24, 2020
@connor4312
Connor Peet (connor4312) deleted the tyriar/extctx_envvarcollection branch April 24, 2020 23:45
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants