Repository navigation
Add logging/warnings when compile probing alters explicit user configuration details - #6180
Merged
Colen Garoutte-Carson (Colengms) merged 14 commits intoSep 29, 2020
Merged
Conversation
…into coleng/compiler_probe_warnings
…into coleng/compiler_probe_warnings
…into coleng/compiler_probe_warnings
…e side for all config types
…into coleng/compiler_probe_warnings
Contributor
|
The cpptools-api will need to know the change of c18 to c17 |
Sean McManus (sean-mcmanus)
approved these changes
Sep 25, 2020
Sean McManus (sean-mcmanus)
requested changes
Sep 28, 2020
Sean McManus (sean-mcmanus)
approved these changes
Sep 28, 2020
Colen Garoutte-Carson (Colengms)
deleted the
coleng/compiler_probe_warnings
branch
September 29, 2020 00:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mostly plumbing. More relevant changes for this are in a PR for the native component.
When combined with the corresponding native PR, addresses:
(others)
I will also have a PR for cpptools-api to make IntelliSenseMode optional from custom config providers, as we can now fully auto-detect it (and don't need to require all custom config providers to replicate that behavior).