Repository navigation
add telemetry updates for openfile - #6257
Merged
Merged
Conversation
Elaheh Rashedi (elahehrashedi)
requested a review
from Colen Garoutte-Carson (Colengms)
October 6, 2020 16:02
Bob Brown (bobbrow)
suggested changes
Oct 12, 2020
added 2 commits
October 16, 2020 14:55
Elaheh Rashedi (elahehrashedi)
force-pushed
the
elrashed/5759_2
branch
from
October 16, 2020 22:37
6114c9e to
4b1e8fc
Compare
Bob Brown (bobbrow)
previously requested changes
Oct 16, 2020
Michelle Matias (michelleangela)
suggested changes
Oct 16, 2020
Elaheh Rashedi (elahehrashedi)
force-pushed
the
elrashed/5759_2
branch
from
October 16, 2020 23:50
710cf4d to
5781f87
Compare
Elaheh Rashedi (elahehrashedi)
requested review from
Bob Brown (bobbrow) and
Michelle Matias (michelleangela)
October 16, 2020 23:52
Michelle Matias (michelleangela)
approved these changes
Oct 16, 2020
Contributor
|
I will clear my review since I'm about to leave for the day. If you fix the last issue about the "setupTime" property, I approve. |
Contributor
|
Elaheh Rashedi (@elahehrashedi) you didn't fix the last bug. I cleared my review so that you could check in after fixing that. Please fix the value of setup time for the warm start case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
telemetry request: #5759
These are the timestamps:
firstFile: when the extension is activated byrealActivationand the active text editor is a c/cpp file. Defined only for "cold" start cases.didOpen: when the file appears in the editor (all files including the first file). Defined for "warm" start cases.setup: when the Intellisense_client constructor is completed and we give the control back to the user at the end oftextDocument_didOpenin language server sideupdateRange: whenpublishDiagnosticsis completedWe defined an extra
startTimetimestamp: when the extension activates, if the active text document is a c/cpp file, the startTime for this file is set tofirstFiletimestamp, otherwise it is set todidOpentimestamp.These are the durations that are being calculated based on timestamps and logged:
activationTime = firstFile - didOpenlogged only for the first file (cold start)setupTime = setup - didOpenupdateRangeTime = updateRange - setuptotalTime = updateRange - startTimethere is a related pull request on the native side.