Repository navigation
Fix 'Build and Debug Active File' race condition with EngineLogs - #6304
Merged
Andrew Wang (WardenGnaw) merged 3 commits intoOct 14, 2020
Merged
Conversation
If users use 'Build and Debug Active File' with "engineLogging", the resolveDebugConfigurations will quickly switch to the output window and `${fileBasenameNoExtension}` will resolve to something similar to `./extension-output-#5`.
This may be a bug with VS Code determining the output window to be a file, but this will unblock users who need to enable engine logging for this scenario.
Andrew Wang (WardenGnaw)
requested review from
Pierson Lee (pieandcakes) and
Sean McManus (sean-mcmanus)
October 13, 2020 19:57
Member
Author
|
VS Code Issue: microsoft/vscode#108619 |
Sean McManus (sean-mcmanus)
approved these changes
Oct 13, 2020
Sean McManus (sean-mcmanus)
deleted the
dev/waan/fixExtensionOutput5Error
branch
October 15, 2020 20:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If users use 'Build and Debug Active File' with "engineLogging", the resolveDebugConfigurations will quickly switch to the output window and
${fileBasenameNoExtension}will resolve to something similar to./extension-output-#5.This may be a bug with VS Code determining the output window to be a file, but this will unblock users who need to enable engine logging for this scenario.
Example broken task.json
Will result in: