Repository navigation
Action bug fixes - #6336
Merged
Colen Garoutte-Carson (Colengms) merged 2 commits intoOct 17, 2020
Merged
Action bug fixes#6336
Conversation
Colen Garoutte-Carson (Colengms)
commented
Oct 16, 2020
Colen Garoutte-Carson (Colengms)
commented
Contributor
- Fixed issue with milestone query not actually being used. This did not surface as an issue, because there is a validation phase that ensure the actions match the criteria, which was properly excluding non-matching issue. (That validation phase is necessary, as GitHub sometimes returns incorrect results).
- Fix an issue with Feature Requests not getting closed if a user was the last to add a comment, despite assignee ping not being enabled (pingDays unset).
- Avoid logging out who left the last comment, if not using pingDays.
Sean McManus (sean-mcmanus)
approved these changes
Oct 17, 2020
Colen Garoutte-Carson (Colengms)
deleted the
coleng/fix_milestone_filter
branch
October 17, 2020 00:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.