Repository navigation
Fixes for Windows ARM64 - #6337
Merged
Merged
Conversation
Colen Garoutte-Carson (Colengms)
approved these changes
Oct 17, 2020
Contributor
Author
|
The TypeScript changes seem okay so far, but the ARM64 binary isn't running and I haven't tested on 32-bit Windows yet. |
…oft/vscode-cpptools into seanmcm/windowsArm64Fixes
Contributor
Author
|
I'm checking this in, but tag parsing isn't working yet... |
| case 'win32': return 'cpptools-win32.vsix'; | ||
| case 'win32': | ||
| switch (platformInfo.architecture) { | ||
| case 'x86_64': return 'cpptool-win32.vsix'; // TODO: Change to cpptools-win64? |
Contributor
There was a problem hiding this comment.
It looks like this is misspelled
Contributor
There was a problem hiding this comment.
This needs to be fixed or else insiders will be broken for x64.
Contributor
Author
There was a problem hiding this comment.
yikes, good catch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still testing this...