Repository navigation
Node Debug & Node Debug 2 unexpected activate when I press F5 in a non-node project #170
Description
Currently if you open a Dart project and press F5 with no launch json, you see this:
We're trying to simplify the first debug experience for Dart & Flutter and having nodejs appear here is somewhat confusing. It seems that the extension only activates when you hit F5. My guess is this happens because of this in package.json:
"activationEvents": [
"onDebugInitialConfigurations",This seems somewhat eager and makes a worse user experience for other extensions. Is there a way this could be prevented?
I've also raised microsoft/vscode#43101 about being able to affect what's displayed here (because we're also trying to avoid Dart/Flutter showing up in the opposite project types) so I don't know if that could also help here (eg. the node debugger would be able to stop itself from appearing in projects that are unrelated).
Activity
DanTup commentedon Feb 8, 2018
I believe this was because we didn't have
languagesdefined against the debugger inpackage.jsonso Code was showing them all. After adding the language, it only shows ours.DanTup commentedon Feb 22, 2018
I actually think there's still something unexpected here.
If I open a Dart project but do not have a Dart file open, and then hit F5, I get a choice between Node and Dart debuggers. As far as I can see, there is no reason for the Node debugger to be appearing -my project is not Node/JavaScript.
If the node extension did not activate, then this would remove the step of selecting a debugger which would be a better user experience (it's confusing to users to see an option that won't work for their project).
weinand commentedon Feb 25, 2018
This is the expected behaviour: If a user has no launch.json and VS Code needs to create one, we show all contributed debuggers in the QuickPick.
As long as the node-debugger is built-in, VS Code list it here.
DanTup commentedon Feb 25, 2018
Andre Weinand (@weinand) Understood; though I think the user experience would be improved if Node didn't show up unless there were some js files in the project or something.