Repository navigation
Display reviewers on description page - #951
Merged
Merged
Conversation
Rachel Macfarlane (RMacfarlane)
requested review from
Ashi Krishnan (queerviolet) and
Peng Lyu (rebornix)
February 13, 2019 23:06
| const seen = new Map<string, boolean>(); | ||
| for (let i = reviewEvents.length -1; i >= 0; i--) { | ||
| const reviewer = reviewEvents[i].user; | ||
| if (!seen.get(reviewer.login)) { |
Contributor
There was a problem hiding this comment.
We need to filter out pull request creator as their comments are being labeled as reviews as well.
| } | ||
| } | ||
|
|
||
| pullRequestModel.prItem.reviewRequests.forEach(request => { |
Contributor
There was a problem hiding this comment.
GitHub.com sorts the results by alphabetical order.
| const descriptionNode = document.getElementById('description'); | ||
| descriptionNode.innerHTML = ''; | ||
| const bodyHTML = !pr.body ? '<i>No description provided</i>' : pr.bodyHTML; | ||
| const descriptionElement = renderComment({ |
Contributor
There was a problem hiding this comment.
is this intentional that now we render the description as a comment? I kind of like the ui before.
Contributor
Author
There was a problem hiding this comment.
Do you mean having the information about the merge as the title of the description?
Peng Lyu (rebornix)
suggested changes
Feb 14, 2019
Peng Lyu (rebornix)
left a comment
Peng Lyu (rebornix)
left a comment
Contributor
There was a problem hiding this comment.
One code change request with two suggestions. The code works as expected.
Peng Lyu (rebornix)
approved these changes
Feb 22, 2019
Peng Lyu (rebornix)
left a comment
Peng Lyu (rebornix)
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Displays reviewers and labels in a sidebar. Will tackle adding new reviewers and labels in a separate PR