Repository navigation
Support "pathMappings" in "launch" debug configs. - #7024
Merged
Eric Snow (ericsnowcurrently) merged 22 commits intoAug 26, 2019
Merged
Eric Snow (ericsnowcurrently) merged 22 commits into
Eric Snow (ericsnowcurrently) merged 22 commits into
Conversation
Kim-Adeline Miguel (kimadeline)
self-requested a review
August 20, 2019 17:40
Kim-Adeline Miguel (kimadeline)
approved these changes
Aug 20, 2019
Codecov Report
@@ Coverage Diff @@
## master #7024 +/- ##
==========================================
+ Coverage 58.29% 58.38% +0.08%
==========================================
Files 483 483
Lines 21347 21421 +74
Branches 3445 3474 +29
==========================================
+ Hits 12445 12507 +62
- Misses 8124 8141 +17
+ Partials 778 773 -5
Continue to review full report at Codecov.
|
Kartik Raj (karrtikr)
suggested changes
Aug 21, 2019
Kartik Raj (karrtikr)
left a comment
Kartik Raj (karrtikr)
left a comment
There was a problem hiding this comment.
I would like to understand the test code before merging it. Things seem a bit magical.
Kartik Raj (karrtikr)
approved these changes
Aug 22, 2019
Author
|
As far as I can tell, the current CI failures here are unrelated to this PR. |
|
Eric Snow (@ericsnowcurrently) You will have to rebase from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(for #3568)
[ ] Test plan is updated as appropriate[ ]package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)[ ] The wiki is updated with any design decisions/details.