Skip to content

Add Markets to manifest #1241

Closed
Closed

Description

Description of the new feature/enhancement

The new store source we are working on requires information regarding the market a given user is in. We need to extend the manifest to we can support behaviors related to markets.

This would be optional, and a manifest could specify either an allow list, or a deny list.

Proposed technical implementation details (optional)

Markets will have an "Allow" list and a "Exclusion" list.

If the client receives both lists and any individual market is in both lists the client will not proceed.
 And the client will inform the user the manifest is invalid due to markets.

If the client receives either (but only one list) the client will only evaluate based on the list it received
If we receive an allow list:
 If the client is in the market included in the allow list, then the install will proceed.
 If the client is not in the market included in the allow list then the install will not proceed.
  And the client will inform the user that the package is not allowed in their market.

If we receive an Exclusion list:
 If the client is in the market included in the exclusion list, then the install will not proceed.
  And the client will inform the user that the package is not allowed in their market.
 If the client is not in the market included in the exclusion list, then the install will proceed.

If the client receives both an allow list and an exclusion list the client will behave as though it only received an allow list.

Installers:
  - InstallerType: exe
    InstallerArchitecture: x64
    InstallerSHA256: 12341234123412341234123412341234123412341234
    InstallerURL: https://www.contoso.com/awesomeapp/1.0.0/awesomeapp.x64.exe
    Markets:
      AllowedMarkets:
       - DE
      ExcludedMarkets:
       - US

Activity

  1. added
    Issue-FeatureThis is a feature request for the Windows Package Manager client.
    Area-ManifestThis may require a change to the manifest
    on Jul 1, 2021
  2. ghost added
    Needs-TriageIssue needs to be triaged
    on Jul 1, 2021
  3. added this to the milestone on Jul 1, 2021
  4. denelon commented on Oct 1, 2021

    @denelon
    CollaboratorAuthor

    "Markets": {
    "description": "The installer markets",
    "type": [ "object", "null" ],
    "oneOf": [
    {
    "properties": {
    "AllowedMarkets": {
    "$ref": "#/definitions/MarketArray"
    }
    },
    "required": [ "AllowedMarkets" ]
    },
    {
    "properties": {
    "ExcludedMarkets": {
    "$ref": "#/definitions/MarketArray"
    }
    },
    "required": [ "ExcludedMarkets" ]
    }
    ]
    },

    #1427

  5. denelon commented on Oct 1, 2021

    @denelon
    CollaboratorAuthor

    This will be completed when winget-pkgs supports the 1.1 schema.

  6. ghost added
    In-PRIssue related to a PR
    on Dec 15, 2021
  7. modified the milestones: , v1.3-Client on Jan 8, 2022
  8. ghost removed
    In-PRIssue related to a PR
    on Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Area-ManifestThis may require a change to the manifestIssue-FeatureThis is a feature request for the Windows Package Manager client.

Type

No type

Projects

  • Status
    Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions