Skip to content

InstallerSuccessCodes in manifest schema does not provide any numerical limits #1406

Closed

Description

@JohnMcPMS

This (and possibly other) field in the schema is meant to represent a number that has some numerical limit. The schema should represent those limits.

For this specific case, the number is compared against 32 bit values returned by OS APIs. The limit should be either the signed, unsigned, or both 32 bit spaces. Both would only be provided as an option to make things easier for authoring, but we would store and use it only one way internally.

Activity

  1. ghost added
    Needs-TriageIssue needs to be triaged
    on Aug 27, 2021
  2. added
    Issue-BugIt either shouldn't be doing this or needs an investigation.
    and removed
    Needs-TriageIssue needs to be triaged
    on Aug 27, 2021
  3. sredna commented on Sep 2, 2021

    @sredna
    Contributor

    A process exiting with a HRESULT is not that common but can happen so the MSB might be set and the full 32-bits should be allowed. On the other hand, dealing with negative ERRORLEVELs in batch files is annoying so limiting to positive 31-bit numbers should be encouraged.

  4. denelon commented on Sep 2, 2021

    @denelon
    Collaborator

    We will need to be able to map negative numbers as well due to some legacy installers. I believe I've seen -214xxxxxxx from a couple of packages.

  5. yao-msft commented on Sep 14, 2021

    @yao-msft
    Contributor

    Fixed as part of #1427

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Issue-BugIt either shouldn't be doing this or needs an investigation.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions