Skip to content

[Zip] Nested Installer Files Validation #2523

Closed

Description

@Trenly
  • Non-Portable Installer Type doesn't warn when PortableCommandAlias is included for a NestedInstallerFile

Note: The below items are likely not implemented yet, as Portable support hasn't been implemented for Zip files yet. I'm placing them here as a consideration to ensure they are validated against

  • Portable Installer Type doesn't throw an error when two entries have the same RelativeFilePath
    • This might be acceptable as long as they have different command aliases?
  • Portable Installer Type doesn't throw an error when two entries have the same PortableCommandAlias

Activity

  1. ghost added
    Needs-TriageIssue needs to be triaged
    on Sep 17, 2022
  2. added
    Issue-BugIt either shouldn't be doing this or needs an investigation.
    and removed
    Needs-TriageIssue needs to be triaged
    on Sep 19, 2022
  3. denelon commented on Sep 19, 2022

    @denelon
    Collaborator

    Ryan (@ryfu-msft) please take a look at this.

  4. ryfu-msft commented on Sep 20, 2022

    @ryfu-msft
    Contributor

    Thanks for catching this, additional validation will be added in #2500

  5. ghost added
    In-PRIssue related to a PR
    on Sep 27, 2022
  6. ghost removed
    In-PRIssue related to a PR
    on Sep 27, 2022
  7. sitiom commented on Jan 26, 2023

    @sitiom
    • This might be acceptable as long as they have different command aliases?

    Seems like this isn't implemented: microsoft/winget-pkgs#94699 (comment)

  8. denelon commented on Jan 26, 2023

    @denelon
    Collaborator

    This version isn't in the validation pipelines yet. We're waiting for the 1.4 client rollout to the majority of users. We want to avoid as much confusion as possible with the "winget" source having .zip-based packages they can't install with earlier versions of winget.

  9. sitiom commented on Jan 26, 2023

    @sitiom

    What I mean is that winget validate fails locally and that an exception should be made for the same RelativeFilePath but different PortableCommandAlias.

  10. denelon commented on Jan 26, 2023

    @denelon
    Collaborator

    Ryan (@sitiom) can you create a new issue with an example?

  11. sitiom commented on Jan 26, 2023

    @sitiom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Issue-BugIt either shouldn't be doing this or needs an investigation.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions